Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#362 add facility to exclude namespaces from generated output file(s) #365

Merged
merged 1 commit into from
Apr 11, 2024
Merged

#362 add facility to exclude namespaces from generated output file(s) #365

merged 1 commit into from
Apr 11, 2024

Conversation

dammitjanet
Copy link

  • Added the excludeNamespaces setting
  • Updated RefitInterfaceImports to exclude the default added namespaces using regular expressions
  • Added additional tests (RefitInterfaceImportTests) to ensure functionality works as expected

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@christianhelle christianhelle self-assigned this Apr 11, 2024
@christianhelle christianhelle added enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code labels Apr 11, 2024
@christianhelle
Copy link
Owner

Thanks for taking the time to look into and implement this @dammitjanet

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (cb135f1) to head (377e274).
Report is 67 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   97.35%   97.37%   +0.02%     
==========================================
  Files          63       63              
  Lines        2421     2440      +19     
==========================================
+ Hits         2357     2376      +19     
  Misses         40       40              
  Partials       24       24
Flag Coverage Δ
unittests 97.37% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

christianhelle
christianhelle approved these changes Apr 11, 2024
View reviewed changes
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

Thanks for being thorough and updating the docs! ❤️

Let's get this merged in as soon as the PR build verification passes

@christianhelle
Copy link
Owner

@all-contributors please add @dammitjanet for code

@allcontributors allcontributors bot mentioned this pull request Apr 11, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@christianhelle

I've put up a pull request to add @dammitjanet! 🎉

@christianhelle christianhelle merged commit 12c2bd3 into christianhelle:main Apr 11, 2024
841 checks passed
@christianhelle christianhelle linked an issue Apr 11, 2024 that may be closed by this pull request
Add the facility to exclude namespaces from generated code #362
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhelle christianhelle christianhelle approved these changes

Assignees

@christianhelle christianhelle

Labels
enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the facility to exclude namespaces from generated code
2 participants
@dammitjanet @christianhelle